docs: 0.4.x readability improvements #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up on this one, I had not pulled main before I updated this(on the If anything needs a force push, let me know :) |
afiqzx
reviewed
Sep 16, 2022
| @@ -4,7 +4,7 @@ As you may have noticed while using Perseus, compiling even very small changes t | |||
|
|
|||
| The first step in addressing this is to figure out whether your app needs exporting or not. If not, then you should use `#[perseus::main_export]` rather than `#[perseus::main(...)]` in your `lib.rs`, and then you don't need to bring in a server integration, which should speed things up slightly. Notably, if you choose not to do this, there's no actual compile-time difference between `perseus export` and `perseus serve` (there used to be, back in the days of `.perseus/`, but those horrors are gone now). As a general rule, apps that *can* go to static files *should* go to static files, because they'll be faster. (It's also more easily possible to push static files to edge networks in deployment, which usually means faster load times for your users, depending on your hosting provider.) | |||
There was a problem hiding this comment.
Shouldn't that be main.rs rather than lib.rs?
Signed-off-by: Ryan Russell <git@ryanrussell.org>
ryanrussell
force-pushed
the
0.4.x-readability-fixes
branch
from
19931db
to
3a5ff45
Compare
arctic-hen7
approved these changes
Sep 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Russell git@ryanrussell.org
Here's the updates for the
docs/0.4.x... submittingnextseparately to make it a little easier in case something needs fixed.-r