Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document styling pitfalls #28

Closed
arctic-hen7 opened this issue Sep 25, 2021 · 7 comments
Closed

Document styling pitfalls #28

arctic-hen7 opened this issue Sep 25, 2021 · 7 comments
Assignees
Labels
C-docs Category: documentation D-easy Difficulty: easy P-high Priority: high S-in-development Status: in development

Comments

@arctic-hen7
Copy link
Member

Is your feature request related to a problem? Please describe.
Without documentation, full-page layouts (e.g. sticky footers and headers with grid layouts) are almost impossible to achieve in Perseus right now. The issue is Perseus' unique DOM hierarchy that's used to store content, which is currently completely undocumented, which leaves users completely in the dark as to why there's an empty <div> taking up 50% of a grid layout.

Describe the solution you'd like
Document styling pitfalls.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@arctic-hen7 arctic-hen7 added C-docs Category: documentation D-easy Difficulty: easy P-high Priority: high S-in-development Status: in development labels Sep 25, 2021
@arctic-hen7 arctic-hen7 self-assigned this Sep 25, 2021
@arctic-hen7
Copy link
Member Author

In a future release, these pitfalls should be minimized as much as possible.

@lukechu10
Copy link
Contributor

Would it be possible to eventually remove this div wrapper? I am not really familiar with the codebase yet so I don't know how big of a change that would be.

@arctic-hen7
Copy link
Member Author

That'll be possible once Sycamore supports creating a template around an existing DOM element.

@arctic-hen7
Copy link
Member Author

One thing that we can do right now though is add a little something to make the server content <div> invisible after transfer is done.

@arctic-hen7
Copy link
Member Author

Done, releasing v0.2.3 once checks pass (or they might not depending on how geckodriver's day is going).

@arctic-hen7
Copy link
Member Author

Okay, somehow I've managed to break i18n and routing with this change, so I'm investigating this...

@arctic-hen7
Copy link
Member Author

Fixed, nested contexts seem to be an issue in Sycamore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-docs Category: documentation D-easy Difficulty: easy P-high Priority: high S-in-development Status: in development
Projects
None yet
Development

No branches or pull requests

2 participants