Renaming of backup directories may affect Smartrecycle and keep backup logic

[framps]

The current logic assumes all backup directories were created by raspiBackup and follow a strict naming convention. If users manually rename backup directories for SR the wrong daily backup may be deleted and for keep backup the number of kept backups will be less than configured.

Make the SR and keep logic robust to ignore any other directories or write an error message and abort the backup if those kind of directories are detected.

[framps]

Both keep and SR strategy assume the backup directories of <hostname> start with <hostname>/ <hostname>, followed by the backup type followed by the backup creation date and time.

Example: <backupPath>/raspberrypi-bullseye/raspberrypi-bullseye-rsync-backup-20220404-224207

If the subdirectories don't follow this naming convention the strategies are screwed up. Thus it's important to add an additional check during startup all existing backup directories follow this naming convention and abort the backup run.

[framps]

Every backup run will check whether the existing backup directories follow the backup directory naming used by raspiBackup. If there exist any other backup directories raspiBackup will terminate with error message RBK0273E

[bcutter]

Is this the reason for removing this in the 0.6.7 config update?

# >>>>> OPTION DELETED in config version "0.1.6" <<<<<
# DEFAULT_USE_HARDLINKS=1

I was/am using this for my rsync-Backups. Not sure if those still work as before udating to 0.6.7 and I really could find nothing about DEFAULT_USE_HARDLINKS in whole https://www.linux-tips-and-tricks.de/de/raspibackup/#alphabetisch :-( Same for RSYNC_IGNORE_ERRORS="23 24" which I use for reasons.

[framps]

Good catch 👍

In one of the first releases of raspiBackup you could set DEFAULT_USE_HARDLINKS=1 to 0 to use rsync if no hardlink support of the underlying filesystem is available. This option is obsolete for a long time already and if you use rsync there has to be hardlink support of the underlying filesystem. Otherwise rsync cannot be used. That's why I removed this option from the config file.

Re RSYNC_IGNORE_ERRORS="23 24" it's not officially documented because it's discouraged to be used but mentioned at some places as a way to disable raspiBackup termination for these RCs and thus can still be used.