New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`commonest` tests fail randomly depending how the sort works #2

Open

4 tasks

francisbarton opened this issue Jan 11, 2022 · 0 comments

Open

4 tasks

`commonest` tests fail randomly depending how the sort works #2

francisbarton opened this issue Jan 11, 2022 · 0 comments

Owner

francisbarton commented Jan 11, 2022

And yes I think it is random (not just unexplained)!

do a good reprex and add it to this issue
ask about this on RStudio Community
learn about set.seed() and why this doesn't fix the issue
if all fails, just fix the test by using a different vector that doesn't have a tie 😉 - it really doesn't matter! (The function works fine and as intended, it's just stipulating a particular test result in advance that allows the test to fail.)

Lextuga007 mentioned this issue

Issues from original package nhs-r-community/NHSRpostcodetools#2

Open

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment