Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each time you click 'Download games' for a user, it adds a copy of every game with Ply count = 0 #218

Closed
pure-blue opened this issue Feb 21, 2024 · 2 comments
Labels
type: bug Something isn't working

Comments

@pure-blue
Copy link

pure-blue commented Feb 21, 2024

Describe the bug

I searched the issues for this, and while there are issues about the percentage of downloaded games being > 100%, I didn't see anything about this specifically.

In the Databases window, each of my games is followed by three copies of that game in which Ply count = 0. Maybe I'm missing something and this isn't a bug, I'm not sure.

Screenshot 2024-02-21 at 11 00 41 AM

Reproduction

  1. Click on Databases to the left

Note

After further investigation I found what seems to be causing this, i.e. the real bug:

Describe the bug

Right after I posted the Issue above, I noticed that in my screenshot below, my most recent game doesn't have three Ply count = 0 copies, but just one. I then went to the User page and clicked on the button to download my games again. I went back to Databases page and saw that the number of Ply count = 0 copies increased by one for each game. Each time I go back and click the button to download my games, the number of Ply count = 0 copies increases by one. So I guess at the time that I initially posted this issue, I had downloaded my games three times. I also noticed that the percentage of downloaded games on the user page increases each time I click the button to download my games, so it appears that this that issue is related to issue #54 concerning percentage of games downloaded. Each time you click 'Download games', it also doubles the number of games listed on the stats pane of the User page, but not the number of games listed for that user on the "Accounts" pane. (I thought that a bandaid would be doing "Delete account" on the User page and reconnecting my account, but all of the Ply = 0 copies are still there after I do this. Is there a way to actually reset the downloaded games so the Ply = 0 games disappear?)

Reproduction

  1. Add a chess.com user on the Users page
  2. Download your games
  3. Play some more games and want to update your downloaded games so that the new games are included
  4. Click "Download games" again to achieve this
  5. Go to Databases and click on your user
  6. Click "Explore" where you will see that while it did add your new games, it also added a copy of every previously downloaded game, each copy having Ply count = 0 (indicating no moves played).
  7. Go back to the Users page to see that 1) Percentage of downloaded games has increased even further above 100%
  8. Click "Update stats" to see that "# Games" on the stats panel has also increased, although "# Games" for that user on the Accounts panel has not changed.

Platform and versions

macOS 14.2.1 23C71 arm64

Stack trace

No response

@pure-blue pure-blue added the type: bug Something isn't working label Feb 21, 2024
@pure-blue pure-blue changed the title Game database list includes three copies of each game with Ply count = 0 Each time you click 'Download games' for a user, it adds a copy of every game with Ply count = 0 Feb 27, 2024
@franciscoBSalgueiro
Copy link
Owner

I'm also adding two new buttons to help removing these duplicates:
image

@pure-blue
Copy link
Author

@franciscoBSalgueiro Thanks a lot! Forgive my ignorance, how do I implement these changes? Do I need to wait for an app update, or is there a way to integrate the changes in the code myself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants