Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect calculation of total games vs downloaded games. #84

Open
Nevsor opened this issue Nov 11, 2023 · 2 comments
Open

Incorrect calculation of total games vs downloaded games. #84

Nevsor opened this issue Nov 11, 2023 · 2 comments
Labels
type: bug Something isn't working

Comments

@Nevsor
Copy link

Nevsor commented Nov 11, 2023

When downloading lichess or chess.com games of a player the number of downloaded games is higher than the number of total games.

I am investigating the source of the discrepancy right now and will hopefully have a PR that fixes this soon.

Example:

grafik

@Nevsor
Copy link
Author

Nevsor commented Nov 11, 2023

Identified sources of discrepancy:

  1. For lichess accounts en-croissant downloads correspondence games, but does not use the number of correspondence games to calculate the total number of games. After accounting for correspondence games the number of downloaded games is still off-by-one.

@dav1312
Copy link

dav1312 commented Nov 11, 2023

#54 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants