Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSSIBLE BUG, NEED SOMEONE WITH LOTS OF DAILY NOTES TO TEST #50

Closed
franciskafieh opened this issue Aug 16, 2022 · 11 comments
Closed

POSSIBLE BUG, NEED SOMEONE WITH LOTS OF DAILY NOTES TO TEST #50

franciskafieh opened this issue Aug 16, 2022 · 11 comments
Labels
confirmed bug Something isn't working help wanted Extra attention is needed question Further information is requested

Comments

@franciskafieh
Copy link
Owner

Not caching getAllDailyNotes may cause slow down if user has lots of daily notes.

To test, please just edit a file. Observe how long it takes to update the list of links in your daily note. Please let me know if there is/is not a slowdown, and how many daily notes you have.

@franciskafieh franciskafieh added help wanted Extra attention is needed question Further information is requested labels Aug 16, 2022
@franciskafieh franciskafieh pinned this issue Aug 16, 2022
@etiennepellegrini
Copy link

I can confirm that not caching getAllDailyNotes2 causes issues with large number of daily notes (~ 500)
 2022-11-28 at 11 09 01 AM

@franciskafieh
Copy link
Owner Author

@liamcain someone is having an issue with caching. i remember in the discord you told me something about this. do you plan on releasing the new version of obsidian-daily-notes-interface anytime soon? thanks!

@franciskafieh franciskafieh added the confirmed bug Something isn't working label Nov 28, 2022
@franciskafieh
Copy link
Owner Author

P.S. @etiennepellegrini thanks for the detailed call tree analysis!

@etiennepellegrini
Copy link

Update: it seems my problem was caused by not having created today's daily note yet - seems like the plugin checks for it every few ms, and needs to list the whole directory for that...

I'd suggest increasing that interval to a few seconds!

@franciskafieh
Copy link
Owner Author

franciskafieh commented Nov 28, 2022

Update: it seems my problem was caused by not having created today's daily note yet - seems like the plugin checks for it every few ms, and needs to list the whole directory for that...

I'd suggest increasing that interval to a few seconds!

yes, that makes more sense. can you let me know what your interval is in your list modified settings? if it's 0, it should NOT be checking every few ms (it should only check when a file is modified)

@etiennepellegrini
Copy link

Ah, that's a bit counter intuitive - I set it to 30 hoping it would reduce the cadence of checks.
I'll set to 0 and report back!

@franciskafieh
Copy link
Owner Author

Yeah, I'm going to change the functionality a bit. I had it working better in 2.1 and then I deleted my local copy so I have to re-do it 😭

@etiennepellegrini
Copy link

That's the worst :-/
I'm still struggling with creating the habit of committing / pushing regularly (to a private remote if you don't want to publish the work in progress)

Good to know you'll work on a fix!

Also, it'd be good to mention that the write interval is in seconds! Had to find the line with writeIntervalInMs = to figure it out :-D

@franciskafieh
Copy link
Owner Author

franciskafieh commented Nov 30, 2022 via email

@franciskafieh
Copy link
Owner Author

I'll set to 0 and report back!

Hey @etiennepellegrini, did setting it to 0 end up fixing the lag for you?

@franciskafieh
Copy link
Owner Author

Note to self: should probably just notify user and disable the plugin until the log note is found in onCreate

@franciskafieh franciskafieh unpinned this issue Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug Something isn't working help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants