Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Add missing sigma calculation for pfind output #8

Closed
pyuxiang opened this issue Feb 1, 2023 · 1 comment
Closed

Add missing sigma calculation for pfind output #8

pyuxiang opened this issue Feb 1, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pyuxiang
Copy link
Collaborator

pyuxiang commented Feb 1, 2023

Once the final time and frequency offset is calculated, we should do one more cross correlation with the modified timestamps and output the significance of the peak (sigma), in line with the output of pfind.c.

This is distinct from the double pfind run on (alice, bob) and (bob, alice) - this belongs to the tests to check for algorithm correctness.

@pyuxiang pyuxiang added the enhancement New feature or request label Feb 1, 2023
@franciumxzf
Copy link
Owner

In the previous pfind, we use the sigma to decide whether the peak is strong enough to start tracking. In this current pfind, as we run time_freq multiple times to make sure the frequency result is correct, so we will put aside this sigma calculation aside first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants