Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte support #72

Closed
gustavopch opened this issue Dec 11, 2021 · 7 comments
Closed

Svelte support #72

gustavopch opened this issue Dec 11, 2021 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gustavopch
Copy link

gustavopch commented Dec 11, 2021

I have a repo using both React and Svelte. I was able to make this plugin work with React, but not with Svelte. I'm just declaring the plugin and extending from the recommended rules. Of course, ESLint is properly configured for Svelte; it's just this plugin that doesn't work.

It detects this error in React:

export const Foo = () => {
  return <div className="p-2 p-4" />
}

But not this error in Svelte:

<div class="p-8 p-2" />

I see that Vue is supported (there are tests for it), so I guess it shouldn't be much hard to also support Svelte. Or maybe it's already supported and there's something else that must be added to the config?

Repro: https://github.com/gustavopch/repro-eslint-plugin-tailwindcss

P.S.: not sure if this is a bug or a feature request TBH.

@gustavopch gustavopch added the enhancement New feature or request label Dec 11, 2021
@francoismassart francoismassart added the help wanted Extra attention is needed label Dec 11, 2021
@francoismassart
Copy link
Owner

Hi @gustavopch,
I'm not familiar with Svelte and I'm currently focusing on upgrading the plugin for TailwindCSS v3, so I won't be able to work on this right away.

Feel free to contribute if you have some expertize. 😉

@francoismassart
Copy link
Owner

@scorsi
Copy link

scorsi commented May 4, 2023

@francoismassart
It's not resolved, your proposition is like parsing typescript file as javascript files... We can't change the parser/processor of svelte files :)
Do you think you can look at this sometime ?

@polyzen
Copy link

polyzen commented May 4, 2023

#214 (comment)

@polyzen
Copy link

polyzen commented May 4, 2023

Might be worth pointing out https://github.com/sveltejs/eslint-plugin-svelte is the new default plugin.

@floriandotorg
Copy link

Hey everyone, may I ask why this one was closed? The plugin still doesn't support Svelte, does it?

@nekochan0122
Copy link

Hello @francoismassart, can u re-open this?
The plugin is not support Svelte yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants