New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Insufficient locking in cmd/ssh3-server #80

Closed

Yawning opened this issue Dec 25, 2023 · 1 comment

Yawning commented Dec 25, 2023

Server.conversationHandler is called from the HTTP3 server's handler in a per-connection go routine.

The handler in cmd/ssh3-server, mutates global state.

Golang maps require synchronization for concurrent writes and/or concurrent reads + writes. The server appears to do both.

The text was updated successfully, but these errors were encountered:

Owner

francoismichel commented Dec 28, 2023

Thanks for the feedback ! I'll have a serious look at it after holidays. :-)

francoismichel mentioned this issue

server: use sync.Map for managing running sessions #103

Merged

francoismichel closed this as completed in

660a6ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment