Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect output format for MSVC #8

Closed
GoogleCodeExporter opened this issue Jul 24, 2015 · 3 comments
Closed

Incorrect output format for MSVC #8

GoogleCodeExporter opened this issue Jul 24, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Create a failing test
2. Run the test in Microsoft Visual Studio

What is the expected output?
unittest.cc(107): error: Value of: false
  Actual: false
Expected: true

What do you see instead?
unittest.cc:107: Failure
Value of: GTEST_IS_NULL_LITERAL(1)
  Actual: false
Expected: true

What version of the product are you using? On what operating system?
1.0.0
Windows
Visual Studio 2005

Please provide any additional information below.
Currently the PrettyUnitTestResultPrinter prints failures in this 
format: "FILE:LINE: Failure", while MSVC expects this format: 
"FILE(LINE): error: ..."!

I've created a patch which uses the correct format iff _MSC_VER defined.

Original issue reported on code.google.com by Balazs....@gmail.com on 9 Jul 2008 at 2:50

Attachments:

@GoogleCodeExporter
Copy link
Author

Code review: http://codereview.appspot.com/2582

Original comment by shiq...@gmail.com on 16 Jul 2008 at 11:19

  • Added labels: OpSys-Windows, Priority-Low, Type-Enhancement
  • Removed labels: Priority-Medium, Type-Defect

@GoogleCodeExporter
Copy link
Author

I think you can close this issue as it works fine with r66.
However, we could improve it with displaying actual and expected values in such 
format that is displayable by VS..

Original comment by Balazs....@gmail.com on 24 Jul 2008 at 2:13

@GoogleCodeExporter
Copy link
Author

Original comment by shiq...@gmail.com on 31 Jul 2008 at 6:37

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant