Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Improvement in command_utils.py #129

Open
Keerthana-T-P opened this issue Jul 14, 2024 · 1 comment
Open

[BUG]Improvement in command_utils.py #129

Keerthana-T-P opened this issue Jul 14, 2024 · 1 comment

Comments

@Keerthana-T-P
Copy link

Describe the bug
*Exception Handling can be added for error clarity like subprocess.CalledProcessError
*Add type annotations for better code clarity and type checking.
*Avoid using shell=True for security reasons, especially with dynamic input. Use a list of arguments instead.

Expected behavior
Error handling and security concerns can be dealt with properly

Bug report issues can be followed by a PR without discussion with a core developer in this issue.

@Keerthana-T-P
Copy link
Author

@frankhart2018 please assign me this issue under gssoc label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant