Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Note: IcepickProcessor took X milliseconds" #26

Closed
AndrewReitz opened this issue Jul 7, 2014 · 6 comments
Closed

Remove "Note: IcepickProcessor took X milliseconds" #26

AndrewReitz opened this issue Jul 7, 2014 · 6 comments

Comments

@AndrewReitz
Copy link

Not a big deal, but I find this text annoying building. Maybe only have it in debug version of the library? If you don't agree, again NBD, just a though.

Also, thanks for building this and your blog post about building it. It inspired me to make my own Annotation Processor.

@frankiesardo
Copy link
Owner

I do agree, that log message has done its job and should go away now. It was included because of #9 and I had no idea how that change would impact performance. So I'd rather have a visible log in the wild to monitor performance than having people complain about Icepick slowing down the build. So far it seems that the performance is still great so there's no point in cluttering down the log output.

No reason to make a release just for that, but it will surely disappear from the next one.

@AndrewReitz
Copy link
Author

Sounds good.

@arturdryomov
Copy link
Contributor

Hey, @frankiesardo, any agenda on this? I can prepare a PR if you wish.

@frankiesardo
Copy link
Owner

@ming13 Thanks, but it's just a one-liner. I'll probably get rid of it when I integrate the nullability improvements.

@arturdryomov
Copy link
Contributor

@frankiesardo Yep, small, but annoying one ;-)

@frankiesardo
Copy link
Owner

Fixed with 460e7c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants