-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Note: IcepickProcessor took X milliseconds" #26
Comments
I do agree, that log message has done its job and should go away now. It was included because of #9 and I had no idea how that change would impact performance. So I'd rather have a visible log in the wild to monitor performance than having people complain about Icepick slowing down the build. So far it seems that the performance is still great so there's no point in cluttering down the log output. No reason to make a release just for that, but it will surely disappear from the next one. |
Sounds good. |
Hey, @frankiesardo, any agenda on this? I can prepare a PR if you wish. |
@ming13 Thanks, but it's just a one-liner. I'll probably get rid of it when I integrate the nullability improvements. |
@frankiesardo Yep, small, but annoying one ;-) |
Fixed with 460e7c8 |
Not a big deal, but I find this text annoying building. Maybe only have it in debug version of the library? If you don't agree, again NBD, just a though.
Also, thanks for building this and your blog post about building it. It inspired me to make my own Annotation Processor.
The text was updated successfully, but these errors were encountered: