Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing custom settings (issue and question) #22

Closed
madysondesigns opened this issue Oct 23, 2018 · 6 comments
Closed

Editing custom settings (issue and question) #22

madysondesigns opened this issue Oct 23, 2018 · 6 comments

Comments

@madysondesigns
Copy link

madysondesigns commented Oct 23, 2018

Hello-

I'm trying to customize the use_slashes and spacing_x/spacing_y options for my workflow, and the plugin doesn't seem to reflect my new settings when using the Group Artboards (Rows) tool work as expected.

What I did:

  • Edited via Reveal in Finder > Show Package Contents > edit ArtboardTools.js values
  • Restarted Sketch
  • Disabled and re-enabled plugin

Some more info:

  • I'm on Sketch 52.2.
  • It seems to order and break rows based on naming and order in the layer palette -- if the artboards that should group are together, it works, but not if the order is mixed.

Bonus question: Do these custom settings persist after a plugin update through Sketch's update mechanism? If not, that would be a great enhancement (or even better, an options page).

@madysondesigns
Copy link
Author

madysondesigns commented Oct 23, 2018

Follow-up: I figured out the issue with spacing_x/spacing_y -- it's defined in multiple places in the file.

User error. It would be nice to have these defined once at the root of the object.

@frankko
Copy link
Owner

frankko commented Oct 25, 2018

  • putting spacing_x and spacing_y in the root object:

I’ll look into that

  • will custom changes persist after a plugin update?

Not currently, no. I don’t think there’s built-in way via Sketch to have something like that persist, which means I’d need to do something on the OS level, which might be a too complicated a task given my current work load. But I’ll see what I can do.

@madysondesigns
Copy link
Author

Thanks for that info. (based on my cursory research, it looks like Sparkle's updater includes delta functionality, so maybe it can be as simple as two separate files?)

But, there is still a problem with use_slashes and naming vs. layer order. If it helps, I can provide an example file.

@frankko
Copy link
Owner

frankko commented Oct 25, 2018

Oh, sorry. Yeah a sample file will be great. All I really need are empty artboards that are named like you have them named. frank at kolo dot io

@frankko
Copy link
Owner

frankko commented Oct 25, 2018

Thanks for the sample file. Unless I’m missing something, I think the problem is that the plugin, as part of the arranging process, doesn’t sort the artboards by name, but rather goes by the order they are in the Layer List. So if you have a few artboards that start with 21, then 20, then 11, then 30, it won’t sort them to 11, 20, 21, 30 before arranging them. They’ll stay in the order they are.

Sorting layers as part of the arranging has been requested before, but I’m probably not going to add that any time soon, if ever. (Primarily I don’t want to assume that everybody that uses the plugin wants their layers sorted.)

There’s a plugin called Sort Me that I use to sort my artboards when I need to that you could look into. There might be others, as well.

@madysondesigns
Copy link
Author

madysondesigns commented Oct 25, 2018

Ah, I was under the impression that the plugin would arrange/group by name, independent of the order in the layers palette – I don't think it's clear in the readme that it depends on that order as well.

I don't need it to reorder them, but I do need to arrange them visually. If that's not the intended functionality, then I can just use Sort Me to order them before arranging. Thanks!

(eta: confirmed, if I use Sort Me first this works exactly as I'd expect/need 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants