Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Are there any plans for this plugin to be updated to support Gatsby V3 or Gatsby V4? #21

Closed
jodiedoubleday opened this issue Nov 11, 2021 · 4 comments
Labels
good first issue Good for newcomers

Comments

@jodiedoubleday
Copy link

jodiedoubleday commented Nov 11, 2021

The plugin seems to still work perfectly on new installs of Gatsby but the Peer Dependencies and Engines still use old versions of Node and Gatsby...

"peerDependencies": {
    "gatsby": "^2.0.0"
  },
  "engines": {
    "node": ">=8.0.0"
  }

are there any plans to push any releases to update these?
I'm happy to look into creating a Pull Request for the work but, I'm a relatively junior developer.

@PaulFelge
Copy link

I would love to see that as well! =)

@franklintarter
Copy link
Owner

Hey, thanks for the suggestion! If either of you would like to make a PR for this I'd be happy to test, merge and release it for you. If not I will try to get around to this when I can but can't promise a timeline 🙏

I imagine Gatsby might have some upgrade steps for this somewhere. I just don't know cause I haven't made a Gatsby project for a bit.

@franklintarter franklintarter added the good first issue Good for newcomers label Nov 23, 2021
@jdeola
Copy link

jdeola commented Dec 31, 2021

I think with this plug-in has finally stopped working with Gatsby v4, even when using --legacy-peer-deps.

Is anyone else having issues?

@franklintarter
Copy link
Owner

@jdeola @PaulFelge @jodiedoubleday

I just got around to this. I followed the migration doc on Gatsby – https://v4.gatsbyjs.com/docs/reference/release-notes/migrating-source-plugin-from-v3-to-v4/

I made this PR – #22

I pushed an NPM update – https://www.npmjs.com/package/gatsby-source-google-places – please update to version 1.0.0

I tested with my local example app and it worked for me. Please try it out and let me know if you have any issues, or re-open this issue. Cheers 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants