Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorizer: "version" should be "1.0" and not "1" in XML declaration #123

Closed
franksouza183 opened this issue May 6, 2022 · 1 comment
Closed
Labels
bug Something isn't working colorizer Related to colorize tool

Comments

@franksouza183
Copy link
Owner

franksouza183 commented May 6, 2022

Some applications treat the file as invalid svg when "version" attribute on xml declaration (<?xml version="1.0" encoding="UTF-8"?>) is set to "1". Some thumbnailers, for example, doesn't recognize it:
image
On the left, the original icon theme

@franksouza183 franksouza183 added bug Something isn't working colorizer Related to colorize tool labels May 6, 2022
@franksouza183 franksouza183 changed the title "version" should be "1.0" and not "1" in XML declaration Colorizer: "version" should be "1.0" and not "1" in XML declaration May 7, 2022
@ElectronicsArchiver
Copy link
Collaborator

Damn those outliers! In this case it can be fixed easily, but in general thats pretty stupid, you'd have to purposely dumb down your cml parser to not convert the number just so you can make sure..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working colorizer Related to colorize tool
Projects
None yet
Development

No branches or pull requests

2 participants