Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bench command line options #361

Closed
brian-pond opened this issue Feb 18, 2017 · 3 comments
Closed

Update Bench command line options #361

brian-pond opened this issue Feb 18, 2017 · 3 comments

Comments

@brian-pond
Copy link

Original discussion here:
https://discuss.erpnext.com/t/cannot-change-default-site-using-bench-command/20540/3

  1. The bench command "set-default-site" does not work. It's checking for a Frappe path that does not exist. Please remove this command. And also update "bench --help' so that this command is not displayed.

  2. The bench command "use" performs the functionality that "set-default-site" was supposed to. However this command is not documented. If you type "bench --help", there is no command "use" displayed. Please update the --help for bench so that the "use" command is shown. The purpose of this command appears to be changing the default bench site.

Please contact me directly if you have any questions.
brian@pondconsulting.net

@vjFaLk
Copy link
Contributor

vjFaLk commented Feb 20, 2017

So, it seems bench set-default-site just calls bench use. Also, there's documentation for bench use in bench --help. I'm not sure why set-default-site is still a thing, maybe for legacy reasons? I can create a PR to remove it.

@brian-pond
Copy link
Author

brian-pond commented Feb 21, 2017

If I run bench --help from the frappe-bench folder, then all commands are shown.
But if I run bench--help from somewhere else, the "Framework commands" are not shown.

If I navigate to the frappe-bench folder, and execute a "use" command, no errors.
If I navigate to the frappe-bench folder, and execute a "set-default-site" command, then I get an error stating "frappe app is not installed"

Bench version 4.1.0. Can you duplicate the above?

@rmehta
Copy link
Member

rmehta commented Mar 9, 2017

I think set-default-site itself needs to be updated so that it is only used for evaluating localhost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants