Add default ERPNext installation to Easy Install script (develop) #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
rmehta
reviewed
Aug 23, 2017
playbooks/develop/centos.yml
Outdated
| @@ -84,3 +84,7 @@ | |||
| # setup development environment | |||
| - include: includes/setup_dev_env.yml | |||
| when: not run_travis and not production | |||
|
|
|||
| # setup an erpnext site called site1.local | |||
| - include: includes/setup_erpnext.yml | |||
There was a problem hiding this comment.
why not just add it to setup_dev_env.yml?
There was a problem hiding this comment.
Yes that makes more sense, I'll do it, thanks
saurabh6790
approved these changes
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rmehta, I'm creating a site called site1.default for default ERPNext installation. Is this approach okay or should we name the site in another way?
Works great on Ubuntu 16.04, I will now test on all other OSes.