Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(minor): Keyboard Interaction #157

Merged
merged 3 commits into from Jun 8, 2022
Merged

fix(minor): Keyboard Interaction #157

merged 3 commits into from Jun 8, 2022

Conversation

shariquerik
Copy link
Member

@shariquerik shariquerik commented Jun 8, 2022 •
edited

Closes: frappe/frappe#17100

  1. Don't save on pressing enter if the value is not changed
  2. While in editing value we should be able to use left, right, up, and down keys instead of changing focus to the next cell.
Before After
DatatableKeyBug DatatableKeyFix

@shariquerik shariquerik merged commit b442863 into frappe:master Jun 8, 2022
@shariquerik shariquerik deleted the keyboard-integration-fix branch June 8, 2022 14:27
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

🎉 This PR is included in version 1.16.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shariquerik shariquerik mentioned this pull request Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with keyboard navigation in report view
1 participant
@shariquerik