fix: use custom formatter when filtering rows #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phot0n
force-pushed
the
fix-filter-custom-formatter
branch
9 times, most recently
from
8aec96d
to
33332b8
Compare
phot0n
commented
Jun 10, 2022
| @@ -527,7 +527,7 @@ export default class CellManager { | |||
| const done = editor.setValue(value, rowIndex, col); | |||
|
|
|||
| // update cell immediately | |||
| this.updateCell(colIndex, rowIndex, value); | |||
| this.updateCell(colIndex, rowIndex, value, true); | |||
There was a problem hiding this comment.
added this for the case when someone edits a cell, as during editing we directly update the cell's content property - this will make sure to refresh the cell's html as well
| const row = this.datamanager.getRow(cell.rowIndex); | ||
| const data = this.datamanager.getData(cell.rowIndex); | ||
| contentHTML = customFormatter(cell.content, row, cell.column, data); | ||
| if (!cell.html || refreshHtml) { |
There was a problem hiding this comment.
added this so that we don't keep on re-formatting cells which are already formatted/have html property set
As datatable renders only some rows at a time and sets each cell's html property based on that rendering, so when someone filters things and only looks at some rows without scrolling the whole grid and tries to filter things (when there is a custom cell formatter), they won't be able to see the data as the filtering is done based on cell's content not html (as it's not set at that point)
phot0n
force-pushed
the
fix-filter-custom-formatter
branch
from
33332b8
to
430d7cf
Compare
shariquerik
approved these changes
Jun 10, 2022
|
🎉 This PR is included in version 1.16.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As datatable renders only some rows at a time and sets each
cell's html property based on that rendering, so when someone
filters things and only looks at some rows without scrolling the whole
grid and tries to filter things (when there is a custom cell formatter),
they won't be able to see the data as the filtering is done based on cell's
content not html (as it's not set at that point)
For example datatable renders date by default in the format: yyyy-mm-dd but if someone uses a custom formatter and changes it to say dd-mm-yyyy, they won't be able to filter/see the data properly
before:
Screen.Recording.2022-06-10.at.11.27.34.AM.mov
after:
Screen.Recording.2022-06-10.at.11.25.29.AM.mov