feat: 馃幐 Total Accumulator hook for totals row #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netchampfaris
requested changes
Jan 22, 2019
and moved function to hooks.totalAccumulator
SaiFi0102
changed the title
|
馃帀 This PR is included in version 1.9.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
netchampfaris
pushed a commit
to frappe/frappe
that referenced
this pull request
Feb 15, 2019
Update for changes in frappe/datatable#55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to add an event "accumulator" which will be used to calculate the totals row.
See the referenced PR for frappe for screenshots.
DataTable looks for
hooks.totalAccumulator. If it finds the function, it will call it otherwise it will use it's default accumulator logic.If the accumulator event function returns a
false, the DataTable's default accumulator logic will be used.