Grant Leave via Leave Policy Assignment is not calculating earned leaves - v13

[harishalwar9]

Grant leaves is not allocating earned leaves prorated

v13.x.x-develop (docker image) hosted in our server and v12.16.2 (locally)

Output of bench version of localhost

erpnext 12.16.2
frappe 12.13.0

Output of bench version of docker image

erpnext v13.x.x-develop () (develop)
frappe  v13.x.x-develop () (develop)

Steps to reproduce the issue (docker image)

1. Set any leave type as earned leave. I set Privilege leaves as 1.5 leaves / month, Sick leaves 0.5 / month, Casual leaves 0.5 / month
2. Set Leave Period as 01-01-2021 to 31-12-2021 (this year), set leave policy for all leave types
3. Search for Leave Policy Assignment in awesome bar, submit Leave policy assignment for the leave period and leave policy and click Grant Leaves button. Today is Feb month but shows no accrued / earned leaves for Jan month.

Showed 0 leaves in balance

1.5 leaves of PL, 0.5 SL and 0.5 CL for Jan 2021 month

Stacktrace / full error message

(paste here)

Additional information

OS version / distribution, ERPNext install method - docker image (version mentioned above)
Attached is the screenshots of leave allocated via Grant button in Leave Policy Assignment page. Screenshot shows previous carry forward leaves too but issue is with earned leaves not being accrued every month. Kindly advise.

Tried v12 running locally as well but even in that Grant leaves is not working. Below is screenshot for reference

[harishalwar9]

Manually allocated leaves (via leave allocation) is calculating pro-rated leaves after 2 months. However Grant Leaves is still not doing so. Kindly advise

[pateljannat]

@harishalwar9 can you share the screenshot of the Leave Policy Assignment as well

[harishalwar9]

Thanks @pateljannat Attached is the screenshot of leave assignment

[pateljannat]

@harishalwar9 I am unable to replicate the issue on version 13. Sharing the steps that I followed. Let me know if I did something different.

1. Created Leave Period for the Financial year 2020-2021

2. Created Leave Policy

3. Carry Forward Leave type.

4. Leave allocation for the financial year 2020-2021.

5. Leave period for the financial year 2021-2022

6. Leave allocation for the financial year 2021-2022

Note unused leaves from the previous allocation which was 4 is reflecting here, which makes the total leaves 8

7. Leave policy assignment

8. Allocated leave shown in the Leave application.

Note: Available Earned Leaves showing as 8 which is the same as Total Leave from the Leave allocation of the financial year 2021-2022

[harishalwar9]

@pateljannat Steps carried out is fine, I am talking about prorated leave allocation which should happen every month automatically based on leave type for the leave period. If you look at my example, the leave period is from 01-01-2021 till 31-12-2021 with 1.5 Leaves per month for Privilege leave type. So by end of March 2021, it should have automatically allocated 4.5 leaves (1.5 for 3 months) however it is not doing. So I have to either manually allocate every month or allocate for the entire year upfront. The check box "earned leave", what I understand, is supposed to calculate every month for the given leave period. Excerpt from ERP documentation about Earned Leave -

2.2 Earned Leave
Earned Leaves are leaves earned by an Employee after working with the company for a certain amount of time. Checking "Is Earned Leave" will allot leaves pro-rata basis by automatically updating Leave Allocation for leaves of this type at intervals set by 'Earned Leave Frequency'.

For example, an Employee is allotted 24 Privilege Leaves in a year, wherein the Privilege Leave is set as Earned Leave with Monthly allotment. In this case, the Employee will earn 2 (24 leaves/12 months) Privilege Leaves at the end of every month. The leave allotment process (background job) will only allot leaves considering the max leaves for the leave type and will round to 'Rounding' for fractions.

[pateljannat]

@harishalwar9 I think this PR will solve the issue
frappe/erpnext#25334

[onlinebizsoft]

@harishalwar9 can you confirm if the issue solved?

[harishalwar9]

@harishalwar9 can you confirm if the issue solved?

I using a docker image. For me to take the PR, I have to migrate from docker and install the source code and then take the pull. I have not tried this yet.