fix: set translated text to link field

[hrwX]

• Fixes Issue/15324
• When selecting a value for Link Field, the English text was set as link field value.
• This PR aims to fix it by setting the translated text as link field value on selection.

Todo:

• Show translated text in the select dropdown
• Set translated value to Link field on select
• Show original value when link field is in focus
• Add option to toggle this behaviour

Behaviour

• Link field loses focus: show the translated name.
• Link field is focused
  • If old value is present
    • If options are one of [Role, DocType]: show the translated name
    • Else: show the name (untranslated) to enable search in untranslated values
  • Else: show what the user typed (untranslated) to enable search in untranslated values
• Value is selected: link field loses focus

Demo

Link to UOM in a custom Item DocType

The UOM names are in english, so the search needs to happen in english. When possible, the translation is displayed.

Before

Bildschirmaufnahme.2022-03-02.um.18.26.01.mov

After

Bildschirmaufnahme.2022-03-02.um.17.58.34.mov

Link to DocType in Customize Form

The DocType names get translated before being searched. This is a preexisting hack in the framework for DocType and Role. In this case, we can search in the translations.

Before

Bildschirmaufnahme.2022-03-02.um.18.22.22.mov

After

Bildschirmaufnahme.2022-03-02.um.18.07.02.mov

https://docs.erpnext.com/docs/v13/user/manual/en/customize-erpnext/customize-form/edit?wiki_page_patch=fdafee2715

[barredterra]

When selecting the link, I can search only in german, but the results will show only in english. This is still a bit confusing.

Once selected the value is translated, which is great.

On other link fields it works well, maybe this is just affecting Customize Form.

[barredterra]

Bildschirmaufnahme.2021-12-28.um.15.46.44.mov

[hrwX]

@barredterra

• The customize form doc_type was excluded from translation.
• Fixed. It'll be translated now.
• 

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

[barredterra]

@hrwX this is working great! A big improvement of localized user experience 🚀

[barredterra]

Looks like cypress tests for the link field need to be updated as well

[codecov]

Codecov Report

Merging #15451 (4d581ab) into develop (8a61c74) will increase coverage by 0.03%.
The diff coverage is 78.57%.

@@             Coverage Diff             @@
##           develop   #15451      +/-   ##
===========================================
+ Coverage    58.18%   58.22%   +0.03%     
===========================================
  Files          768      768              
  Lines        68783    68811      +28     
  Branches      5977     5985       +8     
===========================================
+ Hits         40020    40062      +42     
+ Misses       25134    25133       -1     
+ Partials      3629     3616      -13     

Flag	Coverage Δ
server	63.76% <100.00%> (+0.04%)	⬆️
ui-tests	48.68% <75.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[hrwX]

@hrwX one scenario does not seem to work yet:

1. Take a doctype "A" that is not in translated_search_doctypes hook
2. Activate "Translate Link Fields" for "A"
3. Set your language to something other than english
4. Open a record of docytpe "B" that has a link to "A"
5. Set the link once
6. Edit the link

Observed: typing in English, I see translated results (I have to guess what english words lead to what translated results). After selection, I see the translated value. On edit, I keep seeing and editing the translated value. Therefore I get no more results (searching translation in untranslated values).

Expected: typing in English, I see English results (or both English and translated). After selection, I see the translated value. On edit, I see and edit the untranslated value.

Alternatively, we can make translated_search_doctypes and "Translate Link Fields" the same thing, eliminating above scenario.

[fproldan]

Hi, @barredterra @hrwX this would be backported to v13?

[barredterra]

@fproldan that's the goal. But I can't promise we'll make it, as tricky as this PR is. :D

[barredterra]

Functionality LGTM now

[barredterra]

@hrwX please make sure the tests are working and add docs for this feature and it's delimination to / interaction with translated_search_doctypes hooks.

[hrwX]

https://docs.erpnext.com/docs/v13/user/manual/en/customize-erpnext/customize-form/edit?wiki_page_patch=fdafee2715

[barredterra]

Test with DocType Country: "Translate Link Fields" checked in doctype definition and "Country" in translated_search_doctypes hook. Searches in translations, displays translation, saves original value:

country.mov

Test with DocType Module Def: "Translate Link Fields" not checked in doctype definition and "Module Def" not in translated_search_doctypes hook. Searches in original values, displays translation, saves original value:

Bildschirmaufnahme.2022-05-16.um.14.56.07.mov

[barredterra]

@fproldan you can find the backport to version-13 above.