Missing translation when using “Relink”

[wojosc]

There is one key element which is not translated to far. When relinking E-Mails into DocTypes I have to know the english DocType decription to be able to relink accordingly. Any Ideas where this can be changed?

Also tested for spanish (es) which seems very complete:

My Version:

https://discuss.erpnext.com/t/missing-translation-when-using-relink/43493

[barredterra]

The code should be here: https://github.com/frappe/frappe/blob/hotfix/frappe/core/doctype/communication/communication.js#L93 but I don't know where the error lies.

[wojosc]

I guess the "reference" here is a search in DocType list? This list is also not translated:

But I does this maybe make things difficult as this might influence the whole URI-path logic?

[wojosc]

Using the relink funktionality I noticed it would be usefull if the naming series was included in search. So I am able to search for say QTN and Quotation.

[barredterra]

Same as here: frappe/erpnext#18046

[stale]

This issue has been automatically marked as inactive because it has not had recent activity and it wasn't validated by maintainer team. It will be closed within a week if no further activity occurs.

[wojosc]

stay open

[ankush]

Works after adding a user translation, so it's probably just because translation for this text doesn't exist?

[wojosc]

Hi @ankush thank you for pointing that out with the button. That is not though, what I had in mind with this issue.

As seen in this picture the doctypes which we can select are shown in the translated language but are not searchable in that language. The search only works in english:

Please consider reopening this issue.

Best
Wolfram

[barredterra]

I can confirm: normal link fields to DocType are translated and can be searched in the user's language. However, this dialog uses a special query that does not support translated search:

frappe/frappe/core/doctype/communication/communication.js

Line 110 in 8f245be

"get_query": function() {return {"query": "frappe.email.get_communication_doctype"}}

frappe/frappe/email/__init__.py

Lines 69 to 97 in 8f245be

	@frappe.whitelist()
	@frappe.validate_and_sanitize_search_inputs
	def get_communication_doctype(doctype, txt, searchfield, start, page_len, filters):
	user_perms = frappe.utils.user.UserPermissions(frappe.session.user)
	user_perms.build_permissions()
	can_read = user_perms.can_read
	from frappe.modules import load_doctype_module
	com_doctypes = []
	if len(txt) < 2:
	for name in frappe.get_hooks("communication_doctypes"):
	try:
	module = load_doctype_module(name, suffix="_dashboard")
	if hasattr(module, "get_data"):
	for i in module.get_data()["transactions"]:
	com_doctypes += i["items"]
	except ImportError:
	pass
	else:
	com_doctypes = [
	d[0] for d in frappe.db.get_values("DocType", {"issingle": 0, "istable": 0, "hide_toolbar": 0})
	]
	out = []
	for dt in com_doctypes:
	if txt.lower().replace("%", "") in dt.lower() and dt in can_read:
	out.append([dt])
	return out

Not sure if this is needed at all. Maybe we can remove the special query or significantly reduce the logic.

[ankush]

I agree, this whole query can be removed and filters can be added directly instead. Doesn't seem like it's of any use and re-linking isn't that frequent procedure AFAIK 😅