feat: Login With Email Link #19363
Merged
feat: Login With Email Link #19363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shariquerik
requested review from
a team and
phot0n
and removed request for
a team
github-actions
bot
added
the
add-test-cases
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #19363 +/- ##
===========================================
+ Coverage 62.83% 65.13% +2.30%
===========================================
Files 755 755
Lines 71743 71988 +245
Branches 6117 6119 +2
===========================================
+ Hits 45077 46889 +1812
+ Misses 23169 21606 -1563
+ Partials 3497 3493 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
ankush
requested review from
a team
and removed request for
surajshetty3416 and
phot0n
ankush
requested changes
Dec 20, 2022
|
Add test for this... correct and incorrect auth both. 😔 |
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
|
Passwordless Login sounds better than Login Without Password Edit: Again changed it to Login With Email Link (it should be clear from user's POV) |
made text translatable in email template
shariquerik
force-pushed
the
login-without-password
branch
from
43997f7
to
83bf33c
Compare
shariquerik
commented
Dec 20, 2022
barredterra
reviewed
Dec 20, 2022
barredterra
reviewed
Dec 20, 2022
shariquerik
changed the title
barredterra
reviewed
Dec 20, 2022
sagarvora
reviewed
Dec 20, 2022
sagarvora
reviewed
Dec 20, 2022
rate limit, better description, redirect_post_login, removed subject
shariquerik
changed the title
ankush
added
dont-merge
and removed
add-test-cases
rmehta
requested changes
Dec 24, 2022
Capitalized log in to frappe button
ankush
previously approved these changes
Dec 30, 2022
ankush
force-pushed
the
login-without-password
branch
from
6294a6e
to
2a8773f
Compare
ankush
force-pushed
the
login-without-password
branch
from
2a8773f
to
a43a014
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get a link on the email to log in
Here app name Frappe is coming from App Name set on Website Settings
