Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when installing a custom app with razorpay integration onto a site, frappe throws error, install-app command fails #20507

Closed
saru2020 opened this issue Mar 29, 2023 · 2 comments
Labels

Comments

@saru2020
Copy link

this issue is still occurring with frappe v-14

I've tried installing the payments app before installing the custom app but still facing the same issue and the custom app isn't getting installed at all

@saru2020
Copy link
Author

saru2020 commented Apr 7, 2023

Changed from frappe.integrations.utils import get_payment_gateway_controller to from payments.utils.utils import get_payment_gateway_controller and got the payment redirection working but after successful payment, the app keeps crashing with this error:

11:03:16 watch.1 | ERROR There was an error during rebuilding changes.
11:03:16 watch.1 |
11:03:16 watch.1 | Error: The service was stopped
11:03:16 watch.1 | at Socket.afterClose (/workspace/development/frappe-bench/apps/frappe/node_modules/esbuild/lib/main.js:650:18)
11:03:16 watch.1 | at Socket.emit (node:events:525:35)
11:03:16 watch.1 | at endReadableNT (node:internal/streams/readable:1358:12)
11:03:16 watch.1 | at processTicksAndRejections (node:internal/process/task_queues:83:21)
11:03:16 watch.1 | /workspace/development/frappe-bench/apps/frappe/node_modules/esbuild/lib/main.js:1636
11:03:16 watch.1 | for (const message of messages) {
11:03:16 watch.1 | ^
11:03:16 watch.1 |
11:03:16 watch.1 | TypeError: messages is not iterable
11:03:16 watch.1 | at sanitizeMessages (/workspace/development/frappe-bench/apps/frappe/node_modules/esbuild/lib/main.js:1636:25)
11:03:16 watch.1 | at Object.formatMessages2 [as formatMessages] (/workspace/development/frappe-bench/apps/frappe/node_modules/esbuild/lib/main.js:1434:18)
11:03:16 watch.1 | at /workspace/development/frappe-bench/apps/frappe/node_modules/esbuild/lib/main.js:2112:55
11:03:16 watch.1 | at new Promise ()
11:03:16 watch.1 | at Object.formatMessages (/workspace/development/frappe-bench/apps/frappe/node_modules/esbuild/lib/main.js:2112:14)
11:03:16 watch.1 | at Object.formatMessages (/workspace/development/frappe-bench/apps/frappe/node_modules/esbuild/lib/main.js:1927:70)
11:03:16 watch.1 | at notify_redis (/workspace/development/frappe-bench/apps/frappe/esbuild/esbuild.js:453:33)
11:03:16 watch.1 | at Object.onRebuild (/workspace/development/frappe-bench/apps/frappe/esbuild/esbuild.js:274:6)
11:03:16 watch.1 | at /workspace/development/frappe-bench/apps/frappe/node_modules/esbuild/lib/main.js:1296:27
11:03:16 watch.1 | at Socket.afterClose (/workspace/development/frappe-bench/apps/frappe/node_modules/esbuild/lib/main.js:650:9)
11:03:17 watch.1 | error Command failed with exit code 1.
11:03:17 watch.1 | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
11:03:19 system | watch.1 stopped (rc=0)
11:03:19 system | sending SIGTERM to web.1 (pid 1778)
11:03:19 system | sending SIGTERM to socketio.1 (pid 1784)
11:03:19 system | sending SIGTERM to schedule.1 (pid 1783)
11:03:19 system | sending SIGTERM to worker.1 (pid 1794)
11:03:19 system | schedule.1 stopped (rc=-15)
11:03:19 system | socketio.1 stopped (rc=-15)
11:03:19 system | worker.1 stopped (rc=-15)
11:03:20 system | web.1 stopped (rc=-15)

note: i'm running the dev env with frappe docker

@saru2020
Copy link
Author

saru2020 commented Apr 7, 2023

note: later in the day, the above issue got resolved after stopping the docker and re-running it, I think, but not sure though and the payments module started working, so the only change we had to make was to change the import statement from
from frappe.integrations.utils import get_payment_gateway_controller to from payments.utils.utils import get_payment_gateway_controller

note: though the payments integration is working, the previously mentioned issue still exists

@saru2020 saru2020 closed this as completed Apr 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant