Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic webhook URL #21064

Merged
merged 6 commits into from Jun 2, 2023
Merged

feat: dynamic webhook URL #21064

merged 6 commits into from Jun 2, 2023

Conversation

NagariaHussain
Copy link
Member

@NagariaHussain NagariaHussain commented May 21, 2023

  • feat: support for dynamic URL in webhook
  • test: tests for dynamic URL

CleanShot 2023-05-21 at 16 39 33@2x

@NagariaHussain NagariaHussain requested a review from a team as a code owner May 21, 2023 11:07
@NagariaHussain NagariaHussain requested review from shariquerik and removed request for a team May 21, 2023 11:07
@NagariaHussain
Copy link
Member Author

Will update the docs after merge

@codecov
Copy link

codecov bot commented May 21, 2023

Codecov Report

Merging #21064 (9fa2655) into develop (fe67fcd) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21064      +/-   ##
===========================================
- Coverage    63.95%   63.95%   -0.01%     
===========================================
  Files          764      764              
  Lines        69041    69044       +3     
  Branches      6244     6244              
===========================================
  Hits         44156    44156              
- Misses       21337    21340       +3     
  Partials      3548     3548              
Flag Coverage Δ
server 68.92% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@shariquerik
Copy link
Member

I don't think checkbox is needed. We can just check if url contains {{

@NagariaHussain
Copy link
Member Author

NagariaHussain commented May 22, 2023

Nope, { is a valid character in URL, so people might be using (or want to use) it literally. Hence, the checkbox, otherwise would have directly rendered without conditionals. (For example, if an API takes some kind of template in URL)

Plus, this works like a documentation for those who want to use it.

@NagariaHussain
Copy link
Member Author

😅

@surajshetty3416 surajshetty3416 merged commit e1c23ef into develop Jun 2, 2023
16 of 22 checks passed
@surajshetty3416 surajshetty3416 deleted the feat-dynamic-webhook-url branch June 2, 2023 07:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants