New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamic webhook URL #21064
feat: dynamic webhook URL #21064
Conversation
NagariaHussain
commented
May 21, 2023
•
edited
edited
- feat: support for dynamic URL in webhook
- test: tests for dynamic URL
Will update the docs after merge |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #21064 +/- ##
===========================================
- Coverage 63.95% 63.95% -0.01%
===========================================
Files 764 764
Lines 69041 69044 +3
Branches 6244 6244
===========================================
Hits 44156 44156
- Misses 21337 21340 +3
Partials 3548 3548
Flags with carried forward coverage won't be shown. Click here to find out more. |
I don't think checkbox is needed. We can just check if url contains {{ |
Nope, { is a valid character in URL, so people might be using (or want to use) it literally. Hence, the checkbox, otherwise would have directly rendered without conditionals. (For example, if an API takes some kind of template in URL) Plus, this works like a documentation for those who want to use it. |
😅 |