Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown broken on iOS #24119

Closed
DrZoidberg09 opened this issue Jan 4, 2024 · 6 comments · Fixed by #25472
Closed

Dropdown broken on iOS #24119

DrZoidberg09 opened this issue Jan 4, 2024 · 6 comments · Fixed by #25472
Labels
bug ios safari 💩 Problems related to Safari: https://infrequently.org/2021/04/progress-delayed/ mobile released

Comments

@DrZoidberg09
Copy link
Contributor

DrZoidberg09 commented Jan 4, 2024

When using any kind of dropdown, e.g. LinkField in a modal (e.g. child DocType), you cannot select any item.

This only appears on iOS in any browser there. Other devices are fine.

This completely breaks the usage of Frappe on iOS.

Running on latest v15 Frappe and ERPNext.

Here a picture: You see the dropdown, but cannot select.

grafik

@ankush ankush added ios safari 💩 Problems related to Safari: https://infrequently.org/2021/04/progress-delayed/ mobile labels Jan 4, 2024
@DrZoidberg09
Copy link
Contributor Author

This seems to be caused by the problem that click events dont work on top of a fixed modal in iOS:
https://stackoverflow.com/questions/56601501/ionic-3-click-event-into-modal-doesnt-work-in-ios

However, I dont know what changed as it used to work before.

@ankush ankush changed the title Major issue: Dropdown broken on iOS Dropdown broken on iOS Jan 7, 2024
@cogk
Copy link
Contributor

cogk commented Feb 9, 2024

I did a little bit of investigation on this issue.

Reproducing on Desktop with DevTools (tested on Chrome / Ubuntu):

  • open DevTools
  • enable mobile mode image
  • reload the page
  • try to click an Awesomplete suggestion, or the Link arrow , or the Edit 🖊️ button (nothing works)
  • try to scroll the Awesomplete suggestions (does not work)
  • try to scroll the Awesomplete suggestions by click-dragging the top padding of the suggestion list (it does work!)

Conveniently this reproduces the same issue as on iOS.

Replacing <a> with <button> does help for the Edit button, but not Awesomplete suggestions. There seem to be some magic things done by the browser to detect if a thing is clickable or not on mobile (iOS).

This worked fine a year ago, back when table scrolling was done with basic overflow: scroll, which clipped the Awesomplete suggestions list. Not sure…

This was changed in #18425, I'm too lazy to revert and check if it changes something. It's not that…

@dipakthapa1988
Copy link

Same problem on my IOS devices

@uhrjun
Copy link
Member

uhrjun commented Mar 10, 2024

If filing iPhone specific issues. Please outline the version

@dipakthapa1988
Copy link

image

@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug ios safari 💩 Problems related to Safari: https://infrequently.org/2021/04/progress-delayed/ mobile released
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants