Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console import progress off-by-one #24776

Closed
robproject opened this issue Feb 6, 2024 · 0 comments · Fixed by #24777
Closed

Console import progress off-by-one #24776

robproject opened this issue Feb 6, 2024 · 0 comments · Fixed by #24777
Labels

Comments

@robproject
Copy link
Contributor

Description of the issue

Data import utility displays incorrect progress in console mode due to off-by-one error since frappe.publish_realtime() takes 1-indexed progress while update_progress_bar() takes 0-indexed.

Steps to reproduce the issue

Import any import file as is intended to be used.

frappe.core.doctype.data_import.data_import import import_file

import_file(doctype, file_path, 'insert' or 'update', console=True)

Observed result

Importing 4 records                 : [==================================================] 125%
Successfully imported 4 records out of 4

Expected result

Importing 4 records                 : [==================================================] 100%
Successfully imported 4 records out of 4
@robproject robproject added the bug label Feb 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant