Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RQ worker not compatible with docker #25174

Closed
ankush opened this issue Feb 29, 2024 · 2 comments · Fixed by #25175
Closed

RQ worker not compatible with docker #25174

ankush opened this issue Feb 29, 2024 · 2 comments · Fixed by #25175
Labels

Comments

@ankush
Copy link
Member

ankush commented Feb 29, 2024

On frappe_docked deploys we only see one RQ worker in list view.

This is mostly because they happen to have same PID in respective containers and we treat PID as name.

@ankush ankush added the bug label Feb 29, 2024
@revant
Copy link
Collaborator

revant commented Feb 29, 2024

name seems unique

{'default_result_ttl': 500,
 'worker_ttl': 420,
 'job_monitoring_interval': 30,
 'maintenance_interval': 600,
 'connection': Redis<ConnectionPool<Connection<host=frappe-bench-redis-queue-master,port=6379,db=0>>>,
 'redis_server_version': None,
 'job_class': rq.job.Job,
 'queue_class': rq.queue.Queue,
 'version': '1.15.1',
 'python_version': '3.11.6 (main, Nov 29 2023, 04:30:13) [GCC 12.2.0]',
 'serializer': rq.serializers.DefaultSerializer,
 'name': 'd4b45e7d20a54790a9f1b347054a4530.frappe-bench-erpnext-worker-d-74c486b7d4-q8m46.1.home-frappe-frappe-bench:default',
 'queues': [Queue('home-frappe-frappe-bench:default')],
 '_ordered_queues': [],
 '_exc_handlers': [],
 '_work_horse_killed_handler': None,
 '_shutdown_requested_date': None,
 '_state': 'idle',
 '_is_horse': False,
 '_horse_pid': 0,
 '_stop_requested': False,
 '_stopped_job_id': None,
 'log': <Logger rq.worker (WARNING)>,
 'log_job_description': True,
 'last_cleaned_at': None,
 'successful_job_count': 80782,
 'failed_job_count': 69,
 'total_working_time': 40353.268184,
 'current_job_working_time': 0.0,
 'birth_date': datetime.datetime(2024, 2, 13, 15, 28, 12, 113437),
 'scheduler': None,
 'pubsub': None,
 'pubsub_thread': None,
 '_dequeue_strategy': <DequeueStrategy.DEFAULT: 'default'>,
 'disable_default_exception_handler': False,
 'hostname': 'frappe-bench-erpnext-worker-d-74c486b7d4-q8m46',
 'pid': 1,
 'ip_address': '100.64.0.84:39944',
 '_job_id': None,
 'last_heartbeat': datetime.datetime(2024, 2, 29, 13, 26, 40, 360)}

This added the uuid #9612

@ankush
Copy link
Member Author

ankush commented Feb 29, 2024

name is insanely large 🥴

image

IMO we can just stick with normal UUID instead of adding any of this extra info.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants