Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form View: Need to click "Save" twice #26130

Open
zongo811 opened this issue Apr 23, 2024 · 4 comments
Open

Form View: Need to click "Save" twice #26130

zongo811 opened this issue Apr 23, 2024 · 4 comments
Labels

Comments

@zongo811
Copy link

Description of the issue

If you change the value in a link field again after saving, you have to click the "Save"-button twice to actually save your change.
I reproduced this with ERPnext-DT "Issue".

Context information (for bug reports)

link_defekt

Output of bench version

erpnext 15.20.6
frappe 15.23.0

Steps to reproduce the issue

  1. Create a new Issue, save it and return to List View.
  2. Reopen Issue in Form View. Change Customer. Save.
  3. Change Customer again. Press "Save" again.
  4. Observe that state still is "Not saved".

Observed result

State of Issue stays on "Not saved" after "Save" is pressed.
You have to press "Save" a second time to actually save the changed data.

Expected result

Data gets saved the first time when "Save"-button is pressed-

Stacktrace / full error message

Does not occur.

Additional information

OS version / distribution, Frappe install method, etc.
Debian bullseye, manual install

Workaround

Press "Save" twice or use Strg+S to save data.

@zongo811 zongo811 added the bug label Apr 23, 2024
@ankush
Copy link
Member

ankush commented Apr 23, 2024

This is just because you're still focused on that field, so first click removes focus.

This is just how browsers work?

@ankush ankush added UX and removed bug labels Apr 23, 2024
@cogk
Copy link
Contributor

cogk commented Apr 24, 2024

Yeah, looks like the focus is transferred to the button without activating it.

By curiosity @zongo811, what browser are you using, and is there any chance you have accessbility features enabled such as a text-to-speech screen reader?

@zongo811
Copy link
Author

@cogk On Debian I use Firefox 115.9.1esr, on Windows Edge 124.0.2478.51. No accessibility features are emabled.
I don't remember setting anything special, I assume my settings are the default setting of the browsers.
No plugins were installed either.

@HUMENTH
Copy link
Contributor

HUMENTH commented May 4, 2024

I have also noticed the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants