You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Email ID as user name is bad idea, emails change all the time, Frappe itself has changed it thrice and now all of our employees have mixed user names. There's x@erpnext.com, y@iwebnotes.com and z@frappe.io.
Changes:
User ID should become the name, it can be set by user. E.g. ankush instead of ankush@frappe.io
All the code that sends email should fetch email id field based on user id field.
Disable user ID rename, not required anymore.
Handle ldap and other login providers. (Should work fine for existing sites and new sites)
The text was updated successfully, but these errors were encountered:
I like this idea, and I'm fine with it. However, I believe it would be better to use a random ID for users (in general).
Pros: (all the usual arguments of random IDs)
it might avoid bottlenecks in distributed setups: random id = ~guaranteed to be available
reduce user ID contention and obsolescence: Why am I ankush12? Are there 11 other with the same name?
don't require migration from old system: varchar -> varchar (but it could be nice)
it might be beneficial in the case of data leaks (weak argument)
Cons:
require front-end to make requests everytime it needs to display a user, but i believe this is already the case, and would still be the case with ankush as ID
possibly more difficult to debug
We should consider migrating the existing IDs: old code could still work if name as email is still allowed, we want it to obviously break, in order to avoid problems down the line
Email ID as user name is bad idea, emails change all the time, Frappe itself has changed it thrice and now all of our employees have mixed user names. There's x@erpnext.com, y@iwebnotes.com and z@frappe.io.
Changes:
ankush
instead ofankush@frappe.io
The text was updated successfully, but these errors were encountered: