Integrations -> Utils -> get_request - cover response 204 => "204 No Content"

[tonspar]

Hello @akhilnarang,
because you have last edited file: frappe/integrations/utils.py, so I am kindly asking you for review.
I have a problem with responses w/o content. For example 204 is returned if "DELETE" request is call.

Now I have this error:

Traceback with variables (most recent call last):
  File "apps/frappe/frappe/integrations/utils.py", line 27, in make_request
    elif content_type.startswith("application/") and content_type.split(";")[0].endswith("json"):
      method = 'DELETE'
      url = 'https://graph.microsoft.com/v1.0/me/events/AQMkADY0YTc2OWMxLWJkZjgtNGI4NC1h...'
      auth = ''
      headers = {'Authorization': 'Bearer eyJ0eXAiOiJKV1QiLCJub25jZSI6IkQUFBd...
      data = {}
      json = None
      params = None
      s = <requests.sessions.Session object at 0x7f4efa8f3cd0>
      response = <Response [204]>
      content_type = None
      exc = AttributeError("'NoneType' object has no attribute 'startswith'")
builtins.AttributeError: 'NoneType' object has no attribute 'startswith'

How about firstly check the the status_code like this:

Thanks for you help.

Jiri Sir

[tonspar]

Thank you @akhilnarang

[frappe-pr-bot]

🎉 This issue has been resolved in version 15.29.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[frappe-pr-bot]

🎉 This issue has been resolved in version 14.76.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀