Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paid Feature] Crash when uploading large files #3935

Closed
mhbu50 opened this issue Aug 16, 2017 · 9 comments
Closed

[Paid Feature] Crash when uploading large files #3935

mhbu50 opened this issue Aug 16, 2017 · 9 comments

Comments

@mhbu50
Copy link
Contributor

mhbu50 commented Aug 16, 2017

I am trying to upload 100 mb file as attachment in ERPNext but webpage get crach while uploading!!!
I set "max_file_size": 500000000 in site_config just in case .
see what happen:
anmated

@mhbu50 mhbu50 changed the title Crash when uploading large files [Paid Feature] [Paid Feature] Crash when uploading large files Aug 16, 2017
@mhbu50
Copy link
Contributor Author

mhbu50 commented Aug 21, 2017

Please give me estimate of how much it will cost and how long it will take to add this feature to frappe.

@rmehta
Copy link
Member

rmehta commented Aug 28, 2017

@mhbu50 we might have to use socket.io for such uploads

https://www.npmjs.com/package/socket.io-file

Its a bit experimental, so might take time. Can your client sponsor $500?

@felixvarghese
Copy link
Contributor

felixvarghese commented Aug 28, 2017

@mhbu50 assuming there is nothing inherently built into Frappe that makes large uploads impossible, you would also need to play with your nginx and gunicorn configurations to allow file uploads of this size.

For nginx, you would need to look at the following variables in particular.
client_max_body_size
client_body_timeout

For gunicorn, you would most likely need to increase the timeout. Do this in supervisor with the following flags
--timeout 300

There are a lot of threads on google about this, but most of them involve django. The advice and steps will be the same for frappe though.

@rmehta
Copy link
Member

rmehta commented Aug 28, 2017

@felixvarghese I think the key is timeout, which depends on bandwidth. Today you want 100MB tomorrow you may want 1GB. uploading in chunks via socketio is the best solution IMO. As a bonus you also get a progress indicator 😄

@mhbu50
Copy link
Contributor Author

mhbu50 commented Aug 29, 2017

@rmehta Thanks for your respond, my client is ready to sponsor $500 for this.
How can we proceed?

@PrakashH
Copy link

@mhbu50 Thanks for your interest in sponsoring. Will reply you via Opportunity.

@rmehta
Copy link
Member

rmehta commented Sep 12, 2017

@mhbu50 can you check and approve this fix? #4100

@mhbu50
Copy link
Contributor Author

mhbu50 commented Sep 13, 2017

@rmehta Checked and Approved 👍

@rmehta
Copy link
Member

rmehta commented Sep 14, 2017

Thanksl Let me write a couple of test cases and wrap it up.

@mhbu50 mhbu50 closed this as completed Sep 26, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants