Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wheel to avoid warnings #999

Closed
moltar opened this issue Nov 9, 2022 · 3 comments
Closed

Add wheel to avoid warnings #999

moltar opened this issue Nov 9, 2022 · 3 comments

Comments

@moltar
Copy link

moltar commented Nov 9, 2022

Wondering if the solution outlined here can be added to the bench image?

https://discuss.erpnext.com/t/deprecation-pycountry-is-being-installed-using-the-legacy-setup-py-install-method-because-it-does-not-have-a-pyproject-toml/96079/4?u=_m0

https://github.com/frappe/frappe_docker/blob/main/images/bench/Dockerfile

@revant
Copy link
Collaborator

revant commented Nov 11, 2022

bench image is for easy development and builds, we can add anything that is needed. Just send PR.

EDIT:
I was thinking of building worker image using same frappe/bench as we're doing for nginx image.

@revant
Copy link
Collaborator

revant commented Nov 12, 2022

Can you add it here and check if it solves the issue?

&& PYENV_VERSION=$PYTHON_VERSION_V13 pip install --no-cache-dir virtualenv \
&& PYENV_VERSION=$PYTHON_VERSION pip install --no-cache-dir virtualenv \

If that works we'll add it in image.

@revant
Copy link
Collaborator

revant commented Jan 9, 2023

will be fixed in #1032 using upstream bench which added wheel installation as part of init

@revant revant closed this as completed Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants