Cannot shut down JAPI server from another thread

[fraunhofer-iis-bot]

In GitLab by @kolb on Nov 25, 2019, 10:52

I run a JAPI server as part of a larger program where it is not started from the main() function, but from another thread.

When the program shuts down, I'd like to cleanly shut down the JAPI server as well. That is currently not possible because japi_start_server() is blocking and cannot be interacted with from the outside.

Example code for explanation of the issue:

// called by larger application's framework
void start(void)
{
   d_japi_thread = start_thread(japi_thread); // starts japi_thread() as separate thread
}

// called by larger application's framework
void stop(void)
{
  // Shut down the thread -> how? japi_shutdown() would be nice
  d_japi_thread->join();         // join() blocks forever :-(
}

void japi_thread(void)
{
  japi_context *ctx = japi_init(this);

  // japi setup code left out for brevity

  int ret = japi_start_server(ctx, this->port); // blocking call

  // this part is never reached except if an error occurs

  japi_pushsrv_stop(pushctx_stats);
  japi_destroy(ctx);
}

As pointed out above, a japi_shutdown(ctx) function would be nice that causes japi_start_server() to return. japi_shutdown() would have to be thread-safe.

[fraunhofer-iis-bot]

In GitLab by @fraunhofer-iis-anon on Mar 11, 2020, 15:23

mentioned in commit 62322463ce059dd21fd20c8f3f32cd1dc89cf175

[fraunhofer-iis-bot]

In GitLab by @fraunhofer-iis-anon on Mar 12, 2020, 14:27

This feature request is implemented in MR !45

[fraunhofer-iis-bot]

In GitLab by @cstender on Mar 20, 2020, 09:22

Fixed.

[fraunhofer-iis-bot]

In GitLab by @cstender on Mar 20, 2020, 09:22

closed