Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary null pointer checks #245

Open
elfring opened this issue Mar 1, 2023 · 6 comments
Open

Remove unnecessary null pointer checks #245

elfring opened this issue Mar 1, 2023 · 6 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@elfring
Copy link

elfring commented Mar 1, 2023

An extra null pointer check is not needed in functions like the following.
@adamjw24
Copy link
Member

adamjw24 commented Mar 6, 2023

It's also not wrong tho. We might change it eventually. Feel free to make a PR for it.

@adamjw24 adamjw24 added the question Further information is requested label Mar 6, 2023
@elfring
Copy link
Author

elfring commented Mar 6, 2023

💭 Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?

@adamjw24
Copy link
Member

adamjw24 commented Mar 6, 2023

I've been playing around with that idea but nobody knows this tool around here. We would need external help to set it up.

On similar note, it would also be nice to have a more strict enforcement of style guides.

@adamjw24 adamjw24 added the help wanted Extra attention is needed label Mar 6, 2023
@elfring
Copy link
Author

elfring commented Mar 6, 2023

💭 Would you like to take the C++ guideline “R.11: Avoid calling new and delete explicitly” better into account?

@adamjw24
Copy link
Member

adamjw24 commented Mar 6, 2023

It seems I'm talking to a bot. Locking this conversation. If someone is interested to help, please do. If its necessary to continue this discussion, please open a new issue.

@fraunhoferhhi fraunhoferhhi locked and limited conversation to collaborators Mar 6, 2023
@fraunhoferhhi fraunhoferhhi unlocked this conversation Mar 6, 2023
@adamjw24
Copy link
Member

adamjw24 commented Mar 6, 2023

Unlocking. Apparently I was wrong. Please stick to the discussion until opening a new topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @adamjw24