Helm enhanchements #1174
Merged
Helm enhanchements #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2022 13:54
…al database connection if desired
|
Great, thanks for adding these features! |
added 5 commits
September 23, 2022 08:58
…cause of the fact that you can then set static ips for the loadbalancer with Metallb
|
PR is done;
|
|
Thank you very much for the contribution, and sorry for my late review. I just have some small comments about the default behavior. |
phertweck
reviewed
Oct 11, 2022
phertweck
reviewed
Nov 25, 2022
|
@MichaelTrip: Thanks for updating the PR! Looks fine for me :-) Since the HELM chart also changed in v2.x-Branch, could you please rebase your branch? Afterwards, I can merge it. |
|
I fixed the merge conflicts. Should look fine now. Can you please have one final check? Sorry if something is off. Let's say that merge conflicts are not my core expertise ;-) |
added 7 commits
December 6, 2022 10:32
…al database connection if desired
…cause of the fact that you can then set static ips for the loadbalancer with Metallb
Bumps httpclient from 4.5.13 to 4.5.14. --- updated-dependencies: - dependency-name: org.apache.httpcomponents:httpclient dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dependency-check-maven](https://github.com/jeremylong/DependencyCheck) from 7.3.1 to 7.4.0. - [Release notes](https://github.com/jeremylong/DependencyCheck/releases) - [Changelog](https://github.com/jeremylong/DependencyCheck/blob/main/CHANGELOG.md) - [Commits](jeremylong/DependencyCheck@v7.3.1...v7.4.0) --- updated-dependencies: - dependency-name: org.owasp:dependency-check-maven dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/apache/maven-dependency-plugin/releases) - [Commits](apache/maven-dependency-plugin@maven-dependency-plugin-3.3.0...maven-dependency-plugin-3.4.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-dependency-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Hi, I tried to rebase it but i had a lot of merge conflicts. Can you please check if everything is ok? This was my first rebase ever, so please be gentle ;-) |
hylkevds
requested changes
Dec 7, 2022
|
Hi Hylke, I will try to fix this next friday |
|
Hi Hylke, I changed the Helm chart with your comments. Can you please check again? Thanks! |
hylkevds
approved these changes
Dec 9, 2022
|
Super! Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
customer (@rduivenvoorde) requested for Frost to be implemented in their Kubernetes cluster. I have changed several things to the helm Chart.
For now i created the possibility to use an external Postgis / Postgres server. I will also include several other things:
LoadBalancerofClusterPorton themqttservice./httpandhttpsin theingressfor the http server.I will try to add this to the PR later this week. For now, please don't merge it until i have added the
LoadBalanceroption and theingress httpsoption.