You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Your drop-in replacement for ng-sanitize works well when being included in the usual way via <script> tags.
However, when used in projects which use npm modules like browserify, it causes big problems with other packages which require angular-sanitize.
In addition to this, there's the security implication - angular-sanitize is much more frequently updated than your version, and after performing a (admittedly, not very thorough) comparison of bugs lodged against angular-sanitize, there seem to be many bugfixes which have not made it to your build.
Maintaining a different version of a package with the same name just won't fly.
Please consider either:
A complete fork, with a new name used throughout so that it doesn't cause conflicts with angular-sanitize.
Adding needed functionality to angular-sanitize and submit upstream.
The text was updated successfully, but these errors were encountered:
The issue is that ng-sanitize (as you pointed out) accepts many more tags etc. One can use angular-sanitize without the ng-sanitize, however that breaks cases where the tags etc are not passed in.
It would be great to have an updated version of angular-sanitize integrated into textAngular, but it is beyond the scope of what I can do at this point as I am the only developer at present who is attempting to maintain, etc. I would however love to expand the team. I am at present shifting to angular2 and webpack, but on a different project and would love to see textAngular -> textAngular for angular2.
Your drop-in replacement for ng-sanitize works well when being included in the usual way via <script> tags.
However, when used in projects which use npm modules like browserify, it causes big problems with other packages which require angular-sanitize.
In addition to this, there's the security implication - angular-sanitize is much more frequently updated than your version, and after performing a (admittedly, not very thorough) comparison of bugs lodged against angular-sanitize, there seem to be many bugfixes which have not made it to your build.
Maintaining a different version of a package with the same name just won't fly.
Please consider either:
A complete fork, with a new name used throughout so that it doesn't cause conflicts with angular-sanitize.
Adding needed functionality to angular-sanitize and submit upstream.
The text was updated successfully, but these errors were encountered: