Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please properly fork ng-sanitize #1434

Open
TomMettam opened this issue Jan 11, 2017 · 1 comment
Open

Please properly fork ng-sanitize #1434

TomMettam opened this issue Jan 11, 2017 · 1 comment

Comments

@TomMettam
Copy link

Your drop-in replacement for ng-sanitize works well when being included in the usual way via <script> tags.

However, when used in projects which use npm modules like browserify, it causes big problems with other packages which require angular-sanitize.

In addition to this, there's the security implication - angular-sanitize is much more frequently updated than your version, and after performing a (admittedly, not very thorough) comparison of bugs lodged against angular-sanitize, there seem to be many bugfixes which have not made it to your build.

Maintaining a different version of a package with the same name just won't fly.

Please consider either:

  • A complete fork, with a new name used throughout so that it doesn't cause conflicts with angular-sanitize.

  • Adding needed functionality to angular-sanitize and submit upstream.

@JoelParke
Copy link
Collaborator

The issue is that ng-sanitize (as you pointed out) accepts many more tags etc.   One can use angular-sanitize without the ng-sanitize, however that breaks cases where the tags etc are not passed in.  

It would be great to have an updated version of angular-sanitize integrated into textAngular, but it is beyond the scope of what I can do at this point as I am the only developer at present who is attempting to maintain, etc. I would however love to expand the team.   I am at present shifting to angular2 and webpack, but on a different project and would love to see textAngular -> textAngular for angular2.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants