Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Clearfix needed on taTextElement #611

Closed
JoaoMosmann opened this issue Mar 31, 2015 · 2 comments
Closed

CSS Clearfix needed on taTextElement #611

JoaoMosmann opened this issue Mar 31, 2015 · 2 comments

Comments

@JoaoMosmann
Copy link

The image float problem bellow can be solved by applying a ::after clearfix on the taTextElement

image

@SimeonC SimeonC added the bug label Apr 2, 2015
@JoelParke
Copy link
Collaborator

I am hesitant to add 'clearfix' to the taTextElement.  
This would be trivially done to the code by modifying main.js and changing:

scope.displayElements.text.attr({
'id': 'taTextElement' + _serial,
'contentEditable': 'true',
'ta-bind': 'ta-bind',
'ng-model': 'html',
'ng-model-options': element.attr('ng-model-options')
});

to

scope.displayElements.text.attr({
'id': 'taTextElement' + _serial,
'contentEditable': 'true',
'ta-bind': 'ta-bind',
'ng-model': 'html',
'ng-model-options': element.attr('ng-model-options'),
'class' : 'clearfix'
});

but I worry that this will collide in applications where folks have already crafted their css, etc. to do what they need.
What are your thoughts?

Thanks!

@JoelParke
Copy link
Collaborator

After thinking about this some more. I realized that there is already a 'ta-text-editor-class' attrib set to 'border-around' that I will add 'clearfix' to for the existing demo.
So I will close with an update the demo...

JoelParke added a commit to JoelParke/textAngular that referenced this issue Sep 20, 2016
… a 'clearfix' to the ta-text-editor-class attribute.
JoelParke added a commit that referenced this issue Sep 20, 2016
fix(demo/textAngular.com.html): fixed issue #611 by adding a 'clearfi…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants