Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary table counts tokens and tokens support separately #206

Closed
lauracowen opened this issue Dec 1, 2019 · 2 comments
Closed

Summary table counts tokens and tokens support separately #206

lauracowen opened this issue Dec 1, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@lauracowen
Copy link
Collaborator

In the first bit of summary, I've done 15 distinct roles but only 14 are shown on the page in the list.

Finish Tokens and Finish Tokens Support are separate in the summary table (as parkrun does) but we combined them for the badges.

Test with: 1197634

@lauracowen lauracowen added the bug Something isn't working label Dec 1, 2019
@lauracowen
Copy link
Collaborator Author

lauracowen commented Dec 24, 2019

Conclusions: We should leave the Summary Table (where it currently says "15" in example above) as it is because the Finish Tokens and Finish Tokens Support roles are not necessarily so interchangeable/closely associated at all parkruns as they are at Winchester (say). What should actually be done to fix the extension's inconsistency is to create a new badge for Finish Tokens Support. Not sure what that badge should show though so I'll leave this issue open but won't fix it just yet. Side implication of new badge would be reducing stars that volunteers have achieved on the current combined badge.

@IreShane
Copy link

At Saltaire juniors we have removed the need to have Finish Token support by using knitting stitch holdersto carry the tokens instead of string.
https://www.woolstack.co.uk/knitpro-aluminium-stitch-holders/
Personally I like the way Token and token support are combined for the challenge.

@lauracowen lauracowen added this to Needs triage in Running Challenges bugs Feb 10, 2020
@lauracowen lauracowen moved this from Needs triage to Low priority in Running Challenges bugs Feb 10, 2020
Running Challenges bugs automation moved this from Low priority to Closed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

3 participants