Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync not working on documentation section #1140

Closed
LucaDb opened this issue Jan 30, 2022 · 5 comments 路 Fixed by #1181
Closed

Sync not working on documentation section #1140

LucaDb opened this issue Jan 30, 2022 · 5 comments 路 Fixed by #1181
Labels

Comments

@LucaDb
Copy link

LucaDb commented Jan 30, 2022

Hi, thank you for this wonderful project 馃殌.
I noticed that in the documents section the live reload does not work as expected.

Steps to reproduce the issue

  1. $ fractal new <project-name>
  2. $ fractal start --watch --sync --port <your-port>
  3. Edit and save a doc file (i.e. index.md)

Current result

The page reloads correctly but the changes are not applied, if you try to change a text for example the browser will continue to show the previous version until the server is relaunched.

Expected result

The changes are expected to be applied without relaunching the server

Context

  • Fractal version: 1.5.11/1.5.12
  • Node version: 16.13.0
  • OS: MacOS 12

Thanks

@LucaDb LucaDb added the bug label Jan 30, 2022
@fuhlig
Copy link

fuhlig commented Mar 23, 2022

Experiencing the same.
When having "dynamic docs" (with *.config.js), reloading the config works, but not the template (.md)

@mihkeleidast
Copy link
Member

@LucaDb @fuhlig can you test if #1181 fixes the issue and does not cause any other regressions?

@fuhlig
Copy link

fuhlig commented May 19, 2022

@LucaDb @fuhlig can you test if #1181 fixes the issue and does not cause any other regressions?

First test works like a charm

@bennyb
Copy link

bennyb commented Aug 17, 2022

@LucaDb @fuhlig can you test if #1181 fixes the issue and does not cause any other regressions?

This is working great, any plans to get it merged?

@mihkeleidast
Copy link
Member

Should be released now, sorry for the long delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants