Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles containing forward slashes break routing #231

Closed
jobyh opened this issue Apr 3, 2017 · 1 comment
Closed

Handles containing forward slashes break routing #231

jobyh opened this issue Apr 3, 2017 · 1 comment
Labels

Comments

@jobyh
Copy link

jobyh commented Apr 3, 2017

Thanks for the great work with Fractal - we've been investigating using it as a UI for the component library of an existing platform which already implements component identifiers containing forward-slashes e.g. module_foo/button. Unfortunately using this as a handle causes issues with routing and the following message is displayed when navigating to the preview:

"No matching route found for /components/detail/module_foo/button"

We're working around this currently using a build step to rewrite the forward slash but a possible solution might be to URL encode the handle when used for routing.

@dkhuntrods
Copy link
Member

Thanks @jobyh, this is definitely something to consider. I'll add an investigation of this to the roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants