New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LGTM alerts #302
Fix LGTM alerts #302
Conversation
Commit 55c029e, see LGTM alert snapshot for details:
|
Commit bda01e0, see LGTM alert snapshot for details:
|
Commit e5a7f8e, see LGTM alert snapshot for details:
|
Commit f560ebc, see LGTM alert snapshot for details:
|
The changes from f560ebc are in a third-party library. I prefer not to modify it. The changes from 55c029e The changes from bda01e0 will be included as you suggest, except for the one on line 71. The LGTM changes will be reviewed one by one, but look good to me. Much appreciate the input! Thanks. |
@jdetaeye that sounds great, thank you for taking the time to review my commits. I'm glad I could help contribute to frePPle! Thank you for all your hard work maintaining this library! |
Closing this one. Too many false positives, and low priority to correct all this. |
Hi @jdetaeye, I've referenced LGTM alert snapshot page and fixed two categories of errors:
var
declaration to variables;
semicolons to avoid automated semicolon insertionPlease review when you get a chance, thanks!