-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better the main icon #366
Comments
The toolbar button should be switching to a light version for themes that declare themselves as dark (https://github.com/freaktechnik/advanced-github-notifier/blob/main/images/github-light.svg). |
This is not the application icon. |
@freaktechnik He is talking about https://github.com/freaktechnik/advanced-github-notifier/blob/main/images/icon.svg The dark blue plus sign of that icon is also not easy to distinguish from the black bell as well. |
It's not easy distinguish from the dark background either. |
Describe the bug
If switch to GitHub dark page color mode, then icon becomes barely visible. The same for the Firefox
about:addons
page.Example:
![](https://github.com/freaktechnik/advanced-github-notifier/raw/main/images/icon-48.png)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Another older extension has an example of a better icon:
https://github.com/sindresorhus/notifier-for-github
Example:
![](https://github.com/sindresorhus/notifier-for-github/raw/main/source/icon.png)
Firefox (please complete the following information):
The text was updated successfully, but these errors were encountered: