Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better the main icon #366

Open
andry81 opened this issue Aug 27, 2022 · 4 comments
Open

Better the main icon #366

andry81 opened this issue Aug 27, 2022 · 4 comments
Labels

Comments

@andry81
Copy link

andry81 commented Aug 27, 2022

Describe the bug
If switch to GitHub dark page color mode, then icon becomes barely visible. The same for the Firefox about:addons page.

Example:

To Reproduce
Steps to reproduce the behavior:

  1. Switch GitHub/Firefox to dark page color mode.

Expected behavior
Another older extension has an example of a better icon:
https://github.com/sindresorhus/notifier-for-github

Example:

Firefox (please complete the following information):

  • OS: Windows 7 x64
  • Firefox Version: 103.0.2
  • Extension version: 1.10.0
@andry81 andry81 added the bug label Aug 27, 2022
@freaktechnik
Copy link
Owner

The toolbar button should be switching to a light version for themes that declare themselves as dark (https://github.com/freaktechnik/advanced-github-notifier/blob/main/images/github-light.svg).

@andry81
Copy link
Author

andry81 commented Aug 28, 2022

The toolbar button should be switching to a light version for themes that declare themselves as dark (https://github.com/freaktechnik/advanced-github-notifier/blob/main/images/github-light.svg).

This is not the application icon.

@tooomm
Copy link
Contributor

tooomm commented Sep 11, 2022

@freaktechnik He is talking about https://github.com/freaktechnik/advanced-github-notifier/blob/main/images/icon.svg

add-on page

The dark blue plus sign of that icon is also not easy to distinguish from the black bell as well.

@andry81
Copy link
Author

andry81 commented Sep 12, 2022

The dark blue plus sign of that icon is also not easy to distinguish from the black bell as well.

It's not easy distinguish from the dark background either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants