Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Nightly 58 - PopUp menu grapgical bug #56

Closed
Acid-Crash opened this issue Nov 8, 2017 · 6 comments
Closed

Firefox Nightly 58 - PopUp menu grapgical bug #56

Acid-Crash opened this issue Nov 8, 2017 · 6 comments
Labels

Comments

@Acid-Crash
Copy link

On Firefox Nightly 58 Pop-Up menu seems kinda messed up.
gitpopup
Looks like Hover styling isn't removed correctly.
This appears when hovering over each item and then stopping you hover over "Mark All as read" or "Show all notification"

@freaktechnik
Copy link
Owner

Yeah... I should probably write my own styles either way, since those styles aren't technically supported anymore. Also improves the situation with #49

@Acid-Crash
Copy link
Author

Just a small clarification: it would be great if the future styling could match the one from original Firefox57+ popUp menus (aka Bookmark Menu, or Overflow Menu)

@freaktechnik
Copy link
Owner

It would be my goal to stay close to a native look.

@Acid-Crash
Copy link
Author

I may be mistaking but here are the colors for that menu (default theme).
item:hover -moz-dialog;
separator - hsla(210,4%,10%,.20)
ShowAll - hsla(0,0%,80%,.3)
ShowAll:hover - hsla(0,0%,80%,.45)

@freaktechnik
Copy link
Owner

It should probably end up using https://www.npmjs.com/package/photon-colors the style guide etc.

@freaktechnik
Copy link
Owner

This seems fixed, the own styles have been put on the back-burner as photon versions of the browser style are incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants