Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

Commit

Permalink
fix: don't miss last page in Twitch API (fixes #459)
Browse files Browse the repository at this point in the history
  • Loading branch information
freaktechnik committed Jan 5, 2019
1 parent 3eef8c2 commit 7b79a71
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/background/providers/twitch.js
Expand Up @@ -401,8 +401,8 @@ class Twitch extends GenericProvider {
getPageNumber,
initialPage: getPageNumber(offset, itemsPerPage),
request: (url) => this._qs.queueRequest(url, headers),
fetchNextPage(data, pageSize) {
return offset + pageSize < logins.length;
fetchNextPage() {
return offset < logins.length;
},
getItems(data) {
if(data.parsedJSON && !data.parsedJSON.error) {
Expand Down Expand Up @@ -619,8 +619,8 @@ class Twitch extends GenericProvider {
getPageNumber,
initialPage: getPageNumber(offset, itemsPerPage),
request: (url) => this._qs.queueRequest(url, headers),
fetchNextPage(data, pageSize) {
return offset + pageSize < userIds.length;
fetchNextPage() {
return offset < userIds.length;
},
getItems(data) {
if(data.parsedJSON && !data.parsedJSON.error) {
Expand Down Expand Up @@ -668,8 +668,8 @@ class Twitch extends GenericProvider {
getPageNumber,
initialPage: getPageNumber(offset, itemsPerPage),
request: (url) => this._qs.queueRequest(url, headers),
fetchNextPage(data, pageSize) {
return offset + pageSize < unknownIds.length;
fetchNextPage() {
return offset < unknownIds.length;
},
getItems(data) {
if(data.parsedJSON && !data.parsedJSON.error) {
Expand Down

0 comments on commit 7b79a71

Please sign in to comment.