Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PinCodeControl with scrollview #132

Closed
SE250880 opened this issue Jun 3, 2024 · 8 comments
Closed

PinCodeControl with scrollview #132

SE250880 opened this issue Jun 3, 2024 · 8 comments
Assignees
Labels
question Further information is requested

Comments

@SE250880
Copy link

SE250880 commented Jun 3, 2024

I use your Pincodecontrol in iOS with the latest release and fix KeyboardButtonHeightRequest. Due to space constraints on IPhone in landscape format I have to use a scrollview to enter the pin. But it does not work. The view is not scrollable and the buttons click does not work for all numbers, cancel and backspace button.

@FreakyAli
Copy link
Owner

Add some relevant code

@FreakyAli FreakyAli added the question Further information is requested label Jun 3, 2024
@SE250880
Copy link
Author

SE250880 commented Jun 4, 2024

Ok, here is the code. I put your control in a grid to get some space around it.

    <Label Grid.Row="0" Grid.Column="0" Margin="20" Grid.ColumnSpan="3" FontSize="Large"  HorizontalOptions="Center"   VerticalOptions="End" HorizontalTextAlignment="Center"     Text="🔐 PIN-Code:" />

    <freakyControls:FreakyPinCodeControl
         x:Name="pinCodeCtrl"
         Grid.Row="1"               
         Grid.Column="1"
         BackspaceButtonSource="backspace.png"
         CancelClicked="FreakyPinCodeControl_CancelClicked"
         CodeLength="4"
         FontSize="Large"              
         ItemBackgroundColor="{StaticResource BGTransparent}"
         ItemBorderColor="White"
         ItemFocusAnimation="Scale"
         ItemShape="Circle"                 
         ItemSize="50"
         ItemBorderWidth="1"     
         ItemSpacing="30"
         KeyboardTextColor="Blue"
         HorizontalOptions="Center"             
         KeyboardSpacing="30"               
         KeyboardButtonHeightRequest="60"
         KeyboardButtonWidthRequest="60"            
         KeyboardButtonCornerRadius="20"
         KeyboardBackgroundColor="{StaticResource BGTransparent}"       
         CancelBackgroundColor="{StaticResource BGTransparent}"                
         BackspaceBackgroundColor="{StaticResource BGTransparent}"       
         CodeEntryCompleted="FreakyPinCodeControl_CodeEntryCompleted"                       
         CancelButtonText="X">
    </freakyControls:FreakyPinCodeControl>
</Grid>

grafik

On IPhone the last keyboard row doesn´t work like expected. An in landscape mode it doesn´t scroll.

@FreakyAli
Copy link
Owner

Where is the scroll view?

@SE250880
Copy link
Author

SE250880 commented Jun 4, 2024

Sorry, in the preview the code is cutted. So here is a printscreen:

grafik

@FreakyAli
Copy link
Owner

I cannot replicate this, can you create a sample that can reproduce this...

Also, I have never really seen a pin-code control that can go landscape are you sure you want your user to have this option

@SE250880
Copy link
Author

SE250880 commented Jun 6, 2024

Yes, my app also needs the pin code in landscape format.
I found a solution for myself by adjusting the row definition. I suspect this is a maui bug related to size *.
grafik

@FreakyAli
Copy link
Owner

What should be done with this bug in that case

@FreakyAli
Copy link
Owner

Assuming this was not a bug with the control, but a design flaw I am going to close this bug, feel free to reopen in case of future issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants