Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we use unreachable instead? #4

Closed
mjgpy3 opened this issue Apr 8, 2022 · 6 comments
Closed

Could we use unreachable instead? #4

mjgpy3 opened this issue Apr 8, 2022 · 6 comments

Comments

@mjgpy3
Copy link

mjgpy3 commented Apr 8, 2022

I just saw this library and I was wondering if it's worth exploring instead of maintaining our own.

@mjgpy3
Copy link
Author

mjgpy3 commented Apr 8, 2022

cc @luckysoni

@luckysoni
Copy link
Collaborator

It seems unreachable wouldn't help in the case of reducers for which we have exhaustiveReducer.

@mjgpy3
Copy link
Author

mjgpy3 commented Apr 8, 2022

I see. Though that only seems to be used in 2 places (and is thus a prime candidate for inlining).

@luckysoni
Copy link
Collaborator

We will be using unreachable 👍

@luckysoni
Copy link
Collaborator

I encountered an issue with unreachable and saw that their repo had a pull request to remedy the same but the owner never responded for over a month. I unarchived this repository.

@LinusU
Copy link

LinusU commented Feb 19, 2023

@luckysoni I was the one originally suggesting that PR, and when I didn't get a response I published it under the name ts-unreachable: https://github.com/LinusU/ts-unreachable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants