Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move extension configuration to a ssg property on quasar.config.js #3

Closed
IlCallo opened this issue Mar 9, 2020 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@IlCallo
Copy link

IlCallo commented Mar 9, 2020

Configuration of this AE should probably be moved to a ssg property into quasar.config.js instead of relaying on ssr configuration.
Defaults could still be taken automatically by SSR configuration, the idea is only to allow people to override those without affecting SSR builds too.

In this way it would be easier for devs to generate different apps for ssg and ssr, instead of having to chose one of the 2.

This would also mean to provide adequate TS types augmenting QuasarConf and QuasarContext interfaces, to provide intellisense.

@freddy38510 freddy38510 added the enhancement New feature or request label Jul 16, 2020
@freddy38510
Copy link
Owner

@IlCallo
I made a lot of changes without commiting it. So, i decided to rename the master branch to "v0.0.1".
Then, i made a new master branch with only one commit including all the previous code with all the changes i talked about.

This way, i hope to keep a clean history and use conventionnal naming of commits.

You can see in the updated docs that the configuration has been moved to ssg key (or property ?) on quasar-conf.js.

Fixed in 2bab4ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants